Maniphest T208046

Remove member from non-existent global group
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Rxy
	Oct 26 2018, 1:06 PM

Description

Remove member from non-existent global group

When creating same group name in future, previous member become a new same group name member.

for avoid this, I will remove member from non-existent global group.

MariaDB [centralauth_p]> SELECT * FROM global_user_groups WHERE gug_group NOT IN (SELECT distinct(ggp_group) FROM global_group_permissions GROUP BY ggp_group);
+----------+----------------------+
| gug_user | gug_group            |
+----------+----------------------+
|       99 | Cabal                |
|      575 | URL-upload_(testing) |
+----------+----------------------+
2 rows in set (0.01 sec)

Details

	Subject	Repo	Branch	Lines +/-
	GlobalGroupPermissions: Do not allow deleting groups with members	mediawiki/extensions/CentralAuth	master	+68 -30

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		taavi	T299650 Ghost global accounts having global permissions
		Resolved		taavi	T208046 Remove member from non-existent global group

Event Timeline

Rxy created this task.Oct 26 2018, 1:06 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2018, 1:06 PM

Rxy triaged this task as Low priority.Oct 26 2018, 1:06 PM

Rxy updated the task description. (Show Details)

Caban group member gug_user 99 is not exist.

MariaDB [centralauth_p]> SELECT * FROM globaluser WHERE gu_id = 99;
Empty set (0.01 sec)

for this, I can't remove the entry. Also I found some non-existent user held global permission.

MariaDB [centralauth_p]> SELECT gug_user, gug_group, gu_name FROM global_user_groups LEFT OUTER JOIN globaluser ON gu_id = gug_user WHERE gu_name IS NULL;
+----------+-------------------------+---------+
| gug_user | gug_group               | gu_name |
+----------+-------------------------+---------+
|       99 | Cabal                   | NULL    |
|       99 | steward                 | NULL    |
|      456 | steward                 | NULL    |
|     6888 | global-sysop            | NULL    |
|    25914 | global-rollbacker       | NULL    |
|  1498691 | steward                 | NULL    |
|  1936335 | global-interface-editor | NULL    |
|  3159104 | global-rollbacker       | NULL    |
|  3159104 | global-sysop            | NULL    |
|  3179225 | global-rollbacker       | NULL    |
+----------+-------------------------+---------+
10 rows in set (0.33 sec)

I removed URL-upload_(testing) group by removing membership from Bastique

MariaDB [centralauth_p]> SELECT * FROM global_user_groups WHERE gug_group NOT IN (SELECT distinct(ggp_group) FROM global_group_permissions GROUP BY ggp_group);
+----------+-----------+
| gug_user | gug_group |
+----------+-----------+
|       99 | Cabal     |
+----------+-----------+
1 row in set (0.00 sec)

Rxy moved this task from Untriaged to Low priority on the Stewards-and-global-tools board.Oct 26 2018, 1:37 PM

Rxy moved this task from Backlog to ToDo on the User-Rxy board.

Wondering how to do this.... I can delete the row by running a query at live database, but I'd like to avoid that if possible. Before doing so, I'd like to ask..how this row was introduced?

MarcoAurelio added a parent task: T299650: Ghost global accounts having global permissions.Jan 20 2022, 3:30 PM

Change 755719 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/CentralAuth@master] GlobalGroupPermissions: Do not allow deleting groups with memebers

https://gerrit.wikimedia.org/r/755719

gerritbot added a project: Patch-For-Review.Jan 20 2022, 3:47 PM

Change 755719 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] GlobalGroupPermissions: Do not allow deleting groups with members

https://gerrit.wikimedia.org/r/755719

Zabe edited projects, added MediaWiki-extensions-CentralAuth; removed Patch-For-Review.Jan 25 2022, 4:56 PM

taavi closed this task as Resolved.Jan 25 2022, 4:56 PM

taavi claimed this task.

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.20; 2022-01-31).Jan 25 2022, 5:00 PM