Talk:Web2Cit/Docs/Monitor

Check execution time[edit]

@Superzerocool, the documentation says that monitor.py "will run checks looking for the changes in the configuration files of the domains that have occurred within the last 1 hour ... and generates the work queue in SQLite" and later that runner.py "will search for all domains pending checks whose execution time has expired". But I couldn't find what execution time is set when a check is added to the SQLite queue:

I remember it was one hour plus the time when the check was added to the queue. Is that OK?
Was that for all checks, or only those triggered by config change?
What happened if new config changes are detected after a check has been queued and before it has been run?

Could this be clarified in the docs? Thanks! Diegodlh (talk) 13:42, 8 November 2022 (UTC)[reply]

monitor.py scheduling[edit]

@Superzerocool, monitor.py is currently running every 20 minutes. Given that it is checking for changes in config files within the last hour, and that runner.py (which runs the checks queued by monitor.py) runs every 1 hour, wouldn't it make sense to have monitor.py run every 1 hour too? Maybe a few minutes before runner.py runs? Especially considering that every time monitor.py runs several MediaWiki API requests have to be sent (see T322632). What do you think? Diegodlh (talk) 14:01, 8 November 2022 (UTC)[reply]