User talk:RHaworth/oscoor

Hello Roger, I think that it is not a good idea to call the datum shift from transversemercator.php, as it has nothing to do with the mercator projection! Therefore I suggest that you leave transversemercator.php as it is. Instead in mapsources.php you should call

  list ( $latitude, $longitude ) = HelmertDatumShift ( $this->p->latdeg, $this->p->londeg );
  $osgb36 = new transversemercator();
  $osgb36ref = $osgb36->LatLon2OSGB36 ( $latitude, $longitude );

and of course there muste be a

  require_once ( 'HelmertDatumShift.php' );

at the proper place. (I'd prefer that the file has the same name as the function, things are complicated enough.) In this case, WGS2OSGB() is not needed here. I have written the same suggestion on the German wikipedia for Kolossos. --Telford 16:53, 23 June 2009 (UTC)[reply]

I forgot oscoor.php: for the reason given above I'd prefer to define WGS2OSGB() in oskoor.php instead of transversemercator.php! --Telford 08:22, 24 June 2009 (UTC)[reply]