Talk:WMDE Technical Wishes/Bracket Matching

From Meta, a Wikimedia project coordination wiki
Jump to navigation Jump to search

Feedback from trwiki[edit]

We've been using the feature since January 27th, and I would like to share some feedback based on our experience.

While this is a very nice feature to have along with Syntax Highlighting, I -- and a couple of people I've talked to -- believe that the implementation is somewhat counterintuitive. Meaning: It is inconsistent with a typical computer user's experience with word processors and browsers. The brackets get highlighted when the cursor is next to them, but it looks as if the user has selected the bracket, because the background becomes dark while the bracket itself becomes white. The thing is, this is exactly what happens when you select a text with an ordinary Word processor or browser. You also cannot see where exactly the cursor is because the dark background kind of overrides the blinking. So this feature deprives us of this nice standard functionality, which is confusing to begin with, and gives us the false indication that we are about to delete the brackets, because, well, we think we've selected them. Yes, every single time. :/

New features always need some getting used to, no doubt, but I don't think I will ever get to a point where this will feel natural. I'm sure every possible option has been taken into consideration by the team here, but I strongly suggest switching to a color scheme where only the font color of the bracket itself -- not the background -- changes so that we can see the cursor and not be misled to think that the bracket has been selected.

Vito Genovese 22:54, 13 February 2021 (UTC)

@Vito Genovese: Thanks a lot for your feedback! Our team has tried out different ways to highlight matched brackets already. But we're still hoping that we'll be able to improve the coloring issue when we're working on improving the overall color scheme for syntax highlighting, which is another project in our focus area "Make working with templates easier". -- Best, Johanna Strodt (WMDE) (talk) 15:40, 22 February 2021 (UTC)
Thanks, Johanna. I will be following the developments closely.
Vito Genovese 15:57, 22 February 2021 (UTC)
@Vito Genovese: Hello! The changes made it into the software deployment which is currently being rolled out step by step to all Wikimedia wikis (the Mediawiki train). Usually, changes that make it into the Mediawiki train are available on all Wikipedias by Thursday. But the train is currently blocked, so it might take a few days more. In any case, the changes should be there in the course of the next week at the latest. -- Best, Johanna Strodt (WMDE) (talk) 11:51, 17 March 2021 (UTC)

Feedback from CAwiki[edit]

@Johanna Strodt (WMDE): It's really amazing. As a heavy template editor, my performance has increase. Not because speed, but for reduce errors. I found some small mistakes in highlighting, not in functionality. Is here a good place to tell you ?. Thanks, --Amadalvarez (talk) 16:31, 16 March 2021 (UTC)

@Amadalvarez: Yes, this is a good place. Thanks a lot for your help. -- Best, Johanna Strodt (WMDE) (talk) 11:52, 17 March 2021 (UTC)
Thanks, @Johanna Strodt (WMDE):. It's really a minor and only visual mistake. In ca:special:permalink/26622503 the last closing brackets are not highlighted, although it is paired with the first one and the bracket matching detect it, but do not highlight. That's all by now. --Amadalvarez (talk) 12:34, 18 March 2021 (UTC)

Tracked in Phabricator:
task T277767@Amadalvarez: Thanks a lot! I have reported it on Phabricator (phab:T277767). I personally couldn't reproduce the error and I'm wondering if there might be a connection to the update that happened today. Could you check if the error still exists for you? -- Thanks, Johanna Strodt (WMDE) (talk) 15:23, 18 March 2021 (UTC)

@Johanna Strodt (WMDE):, yes it still runs bad. I tested in Mozilla & Chrome. --Amadalvarez (talk) 15:55, 18 March 2021 (UTC)
@Amadalvarez: Just wanted to let you know that there is a bit more information in the aforementioned ticket (phab:T277767 now. -- Best, 13:29, 22 March 2021 (UTC)