Jump to content

MediaWiki talk:Centralnotice-template-stewnoms

Add topic
From Meta, a Wikimedia project coordination wiki
Latest comment: 6 years ago by MarcoAurelio in topic Obsolete globals

Obsolete globals

[edit]

@Glaisher: this and maybe other scripts related to banners are using deprecated globals such as wgUserName and wgUserGroups. See gerrit:133162 and the warnings in the console on wikis such as Portuguese Wikipedia. Helder 01:55, 15 January 2015 (UTC)Reply

Updated. Thanks for reporting. The same code has been in use since 2011(?). I was planning to do a rewrite this year but didn't have the time and motivation to do it. Only did minor fixes this year. Will update the vote one later. --Glaisher (talk) 05:10, 15 January 2015 (UTC)Reply

@MarcoAurelio, Seddon: This is happening again since Special:Diff/17641551. The same also applies to MediaWiki:Centralnotice-template-stewnoms mobile. Helder 22:38, 25 January 2018 (UTC)Reply

@He7d3r, Seddon (WMF), and Glaisher: I'm sorry but I'm not a JS guy. If you tell me what needs to be done I can fix it though. Thanks. —MarcoAurelio (talk) —MarcoAurelio (talk) 13:14, 27 January 2018 (UTC)Reply
@MZMcBride and -revi: Know by chance what needs to be done here? Regards, —MarcoAurelio (talk) 12:39, 28 January 2018 (UTC)Reply
Uhm, I don't know, maybe Legoktm can help? — regards, Revi 15:35, 28 January 2018 (UTC)Reply
Replace wgUserName with mw.config.get( 'wgUserName' ) and wgUserGroups with mw.config.get( 'wgUserGroups' ) Legoktm (talk) 00:44, 29 January 2018 (UTC)Reply
@Legoktm: [1]? —MarcoAurelio (talk) 10:24, 29 January 2018 (UTC)Reply
Yep! Legoktm (talk) 18:29, 29 January 2018 (UTC)Reply
Okay. If I broke the wiki I guess we'll soon notice. —MarcoAurelio (talk) 19:01, 29 January 2018 (UTC)Reply

Small screen issue

[edit]

Can someone add to #stewnoms

min-height: 65px;

and replace the padding on #stewnoms #black-text with

 padding: 0.75em 40px 1.6em 60px !important;

The first one should make the logo always visible, while the second one makes a space between the translation-link and the text so the text doesn’t overlap the link anymore on devices with smaller screen-width. – KPFC💬 23:14, 15 January 2017 (UTC)Reply

Done[2]. --Vogone (talk) 23:21, 15 January 2017 (UTC)Reply
@Vogone and KPFC: Same issue on MediaWiki:Centralnotice-template-stewvote? Thanks, —MarcoAurelio (talk) 10:54, 26 January 2018 (UTC)Reply
@MarcoAurelio: I don’t see any problems on stewvote. Here you wrote the whole banner completely new. With the @media … expressions the banner is responsive. I tested it and had absolutely no problems. Regards, KPFC💬 15:19, 28 January 2018 (UTC)Reply