Template talk:News draft

From Meta, a Wikimedia project coordination wiki
Jump to navigation Jump to search

Background color[edit]

@Johan (WMF): For me, the previous (and current) one looks weird. The colors I set are from the official Wikimedia color palette. It’s not a big deal which ones we use, especially as normally only translation administrators see it, but using the official colors helps the page to have consistent colors—for example, if you open the current version by oldid, there’s a warning box just below the page title that uses the standard warningbox colors, while the box on the page is more orangeish. For other non-translation admins interested in the discussion, I paste samples below:

My version with standard colors

Johan’s version with custom colors

Tacsipacsi (talk) 12:06, 12 June 2020 (UTC)

News draft template problem.png
Tacsipacsi: I have no opinion on the colours, but see the attached picture to see how it ended up looking in both browsers I tested – this is why I reverted, not because of the colour scheme. /Johan (WMF) (talk) 14:24, 12 June 2020 (UTC)
@Johan (WMF): I see, thanks for the screenshot. Then MediaWiki:Group-translationadmin.css should be extended with
div.translationadmin { display: block !important; }
—where can one reach interface admins on Meta? (I didn’t notice this because I’m not a translation admin here, so I changed CSS by hand when previewing, and my manual changes were correct.) —Tacsipacsi (talk) 14:45, 12 June 2020 (UTC)
Tacsipacsi: Good question. MusikAnimal, I see your account has interface admin rights here – where does one best leave interface admin requests on Meta? /Johan (WMF) (talk) 14:49, 12 June 2020 (UTC)
@Johan (WMF) and Tacsipacsi: Good question indeed. We don't appear to have any fine-grained protected edit request templates, so you could just use the generic {{Edit Protected}} on the talk page and specify that you need an int-admin. Or just ping someone in Special:ListUsers/interface-admin, as you just have. Or, WM:RFH I suppose would result in the right people being contacted. At any rate, I'm not sure about the requested change. Currently the CSS intentionally makes .translationadmin elements inline. Are we trying to override only if it is a div element? Maybe it should select .translationadmin.warningbox instead, leaving any other templates with .translationadmin elements untouched? I don't want to break anything :) MusikAnimal talk 19:45, 12 June 2020 (UTC)
@MusikAnimal: I can’t think of a case where one uses a <div> but means an inline element, it’s just insane—that is what <span> is for. And if I got the regex right, there are exactly two usages of this class. The other one is also a <div>, but that’s also a block thing, so I don’t think it will break anything. Actually, I think it’s more likely to break things like this in the future if you use a more restricted selector (and these breakages are more unexpected like changing warningbox to errorbox breaking the layout) than breaking things right now with the more general selector. —Tacsipacsi (talk) 22:09, 12 June 2020 (UTC)
Yes check.svg Done with Special:Diff/20169682. I left the plain .translationadmin rule as-is, just in case, though I take it isn't really needed. Let me know if you feel it should be removed. Best, MusikAnimal talk 18:17, 13 June 2020 (UTC)
@MusikAnimal: Thanks! The plain rule can become needed at any time (like in a parenthesized comment linking to Special:PageTranslation, not needed by others), so I agree it should be kept. —Tacsipacsi (talk) 18:22, 13 June 2020 (UTC)