Talk:WMDE Technical Wishes/Line Numbering

From Meta, a Wikimedia project coordination wiki
Jump to navigation Jump to search

Status and roadmap[edit]

Hello Johanna, based on diff/53409609 it will not deployed on all wikis, yes? Thanks on advance --Alaa :)..! 08:28, 13 April 2021 (UTC)[reply]

User:علاء You're right. The feature can only be used on wikis that have syntax highlighting (CodeMirror extension), and that's not the case for right-to-left wikis. It's truly a pity that CodeMirror doesn't work for RTL wikis, and that fixing this is out of scope for our project. But: Soon, there will be other changes to make working with templates easier, and those will not be related to CodeMirror. -- Johanna Strodt (WMDE) (talk) 12:33, 13 April 2021 (UTC)[reply]
Thanks Johanna --Alaa :)..! 17:44, 13 April 2021 (UTC)[reply]

First impressions[edit]

Tracked in Phabricator:
task T287383

Good job on the line numbering. Always nice to have.

I think that the text colour is a bit too light for the background. Firefox's dev tools agrees and gives a warning for accessibility. Making it a darker grey would fix this.

I also think that it could help to have a slight difference in the background colour. That way you don't risk line numbers and wikitext blending together.

Here's a mockup of what it could look like:

Line number colour mockup.png

The whole line number column should have the same background colour, but my quick CSS hack didn't manage that :)

/Sebastian Berlin (WMSE) (talk) 07:35, 15 April 2021 (UTC)[reply]

@Sebastian Berlin (WMSE): Thanks for your feedback, it's deeply appreciated. The coloring is the default coloring that came with CodeMirror. But our designer will check if adjusting the colors makes sense in the future. -- Have a good weekend, Johanna Strodt (WMDE) (talk) 08:48, 16 April 2021 (UTC)[reply]
@Johanna Strodt (WMDE) Actually, default colors seems to have been disabled specifically for 2017 Wikitext Editor. Removing .ve-init-mw-desktopArticleTarget .CodeMirror-gutters {background-color: transparent; border-right: 0;} rules produce a much better result, according to me.
Or, better: we keep this reset to .CodeMirror-gutters, but we add coloring rules to linenumber gutter only: .CodeMirror-linenumbers { border-right: 1px solid #ddd; background-color: #f7f7f7; } Pols12 (talk) 16:44, 16 April 2021 (UTC)[reply]
@Pols12: Thanks for the pointer. I've passed this on to the team. -- Wishing you a good week, Johanna Strodt (WMDE) (talk) 13:46, 19 April 2021 (UTC)[reply]

@Sebastian Berlin (WMSE) and Pols12: Hello, just a quick note that the change from phab:T287383 went live last week. -- Best, Johanna Strodt (WMDE) (talk) 08:57, 21 September 2021 (UTC)[reply]

Requests for line numbering on all namespaces[edit]

Hello, the line numbering development is very cool and nice. I would like it to be deployed on all namespaces on my local wiki (tw). Thank you -- Robertjamal12 ~🔔 13:58, 28 February 2022 (UTC)[reply]

@Robertjamal12: Thanks a lot, that's great! Some wikis need a community consensus or some vote for decisions like this. Is this the case on Twi wiki? -- Best, Johanna Strodt (WMDE) (talk) 15:15, 1 March 2022 (UTC)[reply]
No please, but I've been an admin on the wiki for some time now and I've been working on the technical bit as well -- Robertjamal12 ~🔔 15:20, 1 March 2022 (UTC)[reply]
That's absolutely fine by me. You know your wiki best. I guess we'll wait a bit to see which other wikis are interested, and then we'll deploy the feature on all of them at once. -- Best, Johanna Strodt (WMDE) (talk) 15:24, 1 March 2022 (UTC)[reply]
@Robertjamal12: I have added Twi Wikipedia to the list of wikis interested on line numbering on all namespaces: T302852. -- Johanna Strodt (WMDE) (talk) 08:57, 2 March 2022 (UTC)[reply]
Great. Thanks Robertjamal12 ~🔔 10:27, 2 March 2022 (UTC)[reply]